This repository was archived by the owner on Jul 17, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
chore(deps): update pre-commit hook pre-commit/pre-commit-hooks to v6 - #116
Open
renovate[bot] wants to merge 1 commit into
Open
chore(deps): update pre-commit hook pre-commit/pre-commit-hooks to v6 #116renovate[bot] wants to merge 1 commit into
renovate[bot] wants to merge 1 commit into
Conversation
High-level review
This PR upgrades pre-commit/pre-commit-hooks from v5.0.0 to v6.0.0 in .pre-commit-config.yaml. The change is minimal and the config does not use any hooks that were removed or changed incompatibly in v6.
Code quality and best practices
- Compatibility: v6 requires Python >= 3.9. The repo’s Python bindings already require >=3.11 (bindings/python/pyproject.toml), and GitHub runners ship with >=3.10, so CI should be fine. One small safeguard: ensure the pre-commit workflow runs with a Python >=3.9 interpreter (see below) to avoid issues for forks/self-hosted runners.
- Removed hooks in v6: check-byte-order-marker, fix-encoding-pragma. Your config does not reference these, so no action needed.
- Behavior change: file-contents-sorter disallows --unique and --ignore-case together in v6. You’re not using this hook, so no impact.
Architecture and organization
- No architectural impact; this is a straightforward dependency bump in tooling.
CI considerations
- The pre-commit workflow (.github/workflows/pre-commit.yml) uses a custom ./.github/actions/setup-environment. If that action does not explicitly install/configure Python, consider adding an actions/setup-python@v5 step (e.g., python-version: '3.11') before running pre-commit/action to guarantee Python >=3.9 is available for hook environments on all runners, including self-hosted or older images.
- pre-commit/action@v3.0.1 is compatible; no change required.
Testing
- Recommend running pre-commit locally (pre-commit run -a) and verifying the workflow passes on this branch. Given the minimal diff, failures are unlikely.
Documentation
- If any contributors are still on Python 3.8, the new hook set will fail to create environments. Consider a quick note in CONTRIBUTING.md (if present/added later) that pre-commit now requires Python >=3.9.
Conclusion
- LGTM as-is. The upgrade is safe for this repo based on the current configuration. My only actionable suggestion is to ensure the CI environment for the pre-commit job explicitly provides Python >=3.9 to avoid surprises on non-standard runners.
CodSpeed Performance Report
Merging #116 will not alter performance
Comparing renovate/pre-commit-pre-commit-hooks-6.x (c98fc9e) with main (357f1ea)
Summary
✅ 5 untouched
renovate
Bot
force-pushed
the
renovate/pre-commit-pre-commit-hooks-6.x
branch
from
September 25, 2025 19:36
b55e162 to
c98fc9e
Compare
renovate
Bot
force-pushed
the
renovate/pre-commit-pre-commit-hooks-6.x
branch
from
January 19, 2026 18:35
c98fc9e to
d139363
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR contains the following updates:
v5.0.0→v6.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Note: The
pre-commitmanager in Renovate is not supported by thepre-commitmaintainers or community. Please do not report any problems there, instead create a Discussion in the Renovate repository if you have any questions.Release Notes
pre-commit/pre-commit-hooks (pre-commit/pre-commit-hooks)
v6.0.0: pre-commit-hooks v6.0.0Compare Source
Fixes
check-shebang-scripts-are-executable: improve error message.Migrating
file-contents-sorter: disallow--uniqueand--ignore-caseat the sametime.
check-byte-order-markerandfix-encoding-pragma.check-byte-order-marker: migrate tofix-byte-order-marker.fix-encoding-pragma: migrate topyupgrade.Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.