-
-
Notifications
You must be signed in to change notification settings - Fork 748
[WIP] 3.7.3 I.seeResponseContainsJson not working #5081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
Copilot stopped work on behalf of
kobenguyent due to an error
August 20, 2025 13:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixed the issue with
I.seeResponseContainsJson()
not working correctly in version 3.7.3. The problem was in the_assertContains
method when dealing with arrays.Root Cause:
_assertContains
method was treating arrays as objects and doing index-by-index comparison instead of checking if each expected array element had a corresponding match in the actual arraySolution:
_assertContains
method to properly handle array matching by detecting when expected values are arrays and implementing proper element-by-element matching logicChanges Made:
_assertContains
method inlib/helper/JSONResponse.js
to handle arrays correctlytest/helper/JSONResponse_test.js
to match new error messagesassert
vsexpect
)Validation:
The fix now correctly searches through all array elements for matches instead of stopping at the first element, restoring the behavior that worked in version 3.6.5.
Fixes #4993.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.