-
-
Notifications
You must be signed in to change notification settings - Fork 750
[WIP] Playwright: I.waitForText() causes unexpected delay equal to waitForTimeout
value at the end of test suite
#5077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kobenguyent 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.
I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.
Co-authored-by: kobenguyent <7845001+kobenguyent@users.noreply.github.com>
Copilot stopped work on behalf of
kobenguyent due to an error
August 20, 2025 05:03
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Fixed the issue where
I.waitForText()
causes an unexpected delay equal towaitForTimeout
value at the end of test suite in Playwright helper.Solution Implemented
waitForText
method inlib/helper/Playwright.js
promiseRetry
with aggressive retry settings continues running in backgroundRoot Cause
The issue was in the
waitForText
method which usesPromise.race
with multiple strategies, including apromiseRetry
with extremely aggressive settings:retries: 1000
minTimeout: 500ms
maxTimeout: 500ms
factor: 1
This meant up to 1000 ×ばつ 500ms = 500 seconds (8+ minutes) of background execution even after the main promise resolved.
Solution
Two-part fix implemented:
shouldStop
boolean to signal the promiseRetry to stop when the race resolves{retries: 1000, minTimeout: 500, maxTimeout: 500, factor: 1}
to{retries: 10, minTimeout: 100, maxTimeout: 500, factor: 1.5}
which provides reasonable retry behavior with exponential backoffThe fix is minimal, surgical, and maintains all existing functionality while eliminating the problematic delay.
Fixes #4999.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.