Skip to content

fix: sessions playwright traces - naming convention and error handling #5073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

kobenguyent merged 2 commits into codeceptjs:3.x from kobenguyent:fix/session-playwright-traces-kobenguyent

Aug 19, 2025

Merged

fix: sessions playwright traces - naming convention and error handling #5073

kobenguyent merged 2 commits into codeceptjs:3.x from kobenguyent:fix/session-playwright-traces-kobenguyent

Aug 19, 2025

Conversation

Copy link

Collaborator

@kobenguyent kobenguyent commented Aug 19, 2025

This PR fixes session-related issues in the Playwright helper:

Issues Fixed:

Naming Convention: Changed session artifact naming from ${test.title}_${sessionName} to ${sessionName}_${test.title} to prevent file collisions when test titles are truncated
Tracing Errors: Added graceful error handling for "Must start tracing before stopping" errors in session contexts
Main Session Processing: Fixed duplicate main session processing by excluding empty session names

Changes Made:

lib/helper/Playwright.js: Updated _failed() and _passed() methods with improved session handling
test/helper/Playwright_test.js: Added comprehensive tests covering all fix scenarios

Testing:

✅ All 4 new session tests pass
✅ Validates proper naming convention
✅ Tests error handling for invalid contexts
✅ Ensures main session isn't duplicated

Related to issue: Session/Playwright traces naming convention and error handling improvements.


 fix: sessions playwright traces

bbae4be

@kobenguyent kobenguyent mentioned this pull request

fix : naming convention session / main erasing with long test.title/tags #4992

Closed

32 tasks


 fix: Update screenshotOnFail_test.js

110f6db

@kobenguyent kobenguyent merged commit ff63f70 into codeceptjs:3.x

11 of 12 checks passed

@kobenguyent kobenguyent deleted the fix/session-playwright-traces-kobenguyent branch

August 19, 2025 10:15

This was referenced Aug 19, 2025

release 3.7.4 #5075

Merged

having playwright trace when using multiple sessions sessions #4981

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment