-
Notifications
You must be signed in to change notification settings - Fork 5
🔧 refactor ci pipeline diagnostics for improved clarity and efficiency#143
🔧 refactor ci pipeline diagnostics for improved clarity and efficiency #143gimlichael merged 2 commits intomain from
Conversation
📝 WalkthroughWalkthroughCI workflow adjustments: the Linux integration test apphost permission diagnostic now echoes matrix.configuration (not inputs.configuration) and replaces configuration-specific bin/obj paths with wildcard glob patterns to target all matrix-driven build outputs. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR refactors the CI pipeline diagnostics in .github/workflows/ci-pipeline.yml to make Linux permission/executability troubleshooting more general and less noisy by focusing on bin/ + obj/ file permissions and targeted executable diagnostics.
Changes:
- Generalizes the brute-force
chmodand file discovery from configuration/framework-specificbin/objpaths to allbin/andobj/directories. - Streamlines diagnostics output by truncating lists, suppressing non-essential errors, and reducing deep-dive output to key ELF/shebang signals.
- Removes broader environment/.NET/git context output to keep the step focused on executability issues.
Uh oh!
There was an error while loading. Please reload this page.
This pull request simplifies and generalizes the CI pipeline diagnostics step in
.github/workflows/ci-pipeline.yml. It removes some .NET-specific and configuration-specific logic, broadens the search for executables, and streamlines the output for easier debugging of permission and execution issues.Diagnostics and search improvements:
chmodand file search to include all files in anybinorobjdirectories, not just those under a specific configuration or target framework.Output and debug information changes:
Summary by CodeRabbit