-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Comments
added scroll restoration on forward/backward navigation#1878
Open
KitsuneKode wants to merge 1 commit intocode100x:main from
Open
added scroll restoration on forward/backward navigation #1878KitsuneKode wants to merge 1 commit intocode100x:main from
KitsuneKode wants to merge 1 commit intocode100x:main from
Conversation
tarun-katal
commented
Sep 12, 2025
- isn't ref logic redundant?
- also is there any use of { scroll: false } as we're using window.scrollTo logic in useEffect anyway?
it seemed to work fine w/o them too..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Fixes:
The course content page scrolls to the top on navigation(backward/forward).
Scrolling through the same weeks of content again and again to find the video/week is just straight up annoying.
This PR fixes it, restores back to the point before navigation.
Checklist before requesting a review