-
Notifications
You must be signed in to change notification settings - Fork 40
uglify-js@2.8.1 breaks build 🚨 #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
uglify-js just published its new version 2.8.1.
This version is covered by your current version range and after updating it in your project the build went from success to failure.
As uglify-js is "only" a devDependency of this project it might not break production or downstream projects, but "only" your build or test tools – preventing new deploys or publishes.
I recommend you give this issue a high priority. I’m sure you can resolve this 💪
Of course this could just be a false positive, caused by a flaky test suite, or third parties that are currently broken or unavailable, but that would be another problem I’d recommend working on.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 163 commits .
320984cv2.8.14365a51temporarily disablesreduce_vars(#1517)858e6c7warn & drop#__PURE__iff IIFE is dropped (#1511)0b0296ev2.8.0872270bimprove error messages (#1506)b1c593aadd harmony branch details in README (#1507)13be50afaster tree transversal (#1462)16cd5d5consolidateevaluate&reduce_vars(#1505)834f9f3update docs forpure_funcs&drop_console(#1503)cf0951fallow --in-source-map inline (#1490)852f784Avoid using exports when undefined (#1471)229e42cMerge pull request #1485 from alexlamsl/merge-2.8.04e49302enablecollapse_vars&reduce_varsby default1e51586Support marking a call as pured48a308Fix: AST_Accessor missing start / end tokensThere are 163 commits in total. See the full diff.
Screencast
Try it today. Free for private repositories during beta.