-
Notifications
You must be signed in to change notification settings - Fork 32
Fixes from phpstan#91
Closed
szepeviktor wants to merge 4 commits intocloudinary:master from
szepeviktor:fixes/from-phpstan
Closed
Fixes from phpstan #91szepeviktor wants to merge 4 commits intocloudinary:master from szepeviktor:fixes/from-phpstan
szepeviktor wants to merge 4 commits intocloudinary:master from
szepeviktor:fixes/from-phpstan
Conversation
```bash vendor/bin/phpcs --standard=WordPress-VIP-Go --exclude=WordPress.WP.TimezoneChange \ cloudinary-image-management-and-manipulation-in-the-cloud-cdn/php/ cloudinary-image-management-and-manipulation-in-the-cloud-cdn/cloudinary.php ``` as per Automattic/VIP-Coding-Standards#457
@szepeviktor
szepeviktor
changed the title
(削除) Fixes/from phpstan (削除ここまで)
(追記) Fixes from phpstan (追記ここまで)
May 29, 2020
Contributor
DavidCramer
commented
May 29, 2020
Thanks@szepeviktor ! I really appreciate it. I'll review this over the weekend!
Contributor
pereirinha
commented
Sep 27, 2021
Thank you, @szepeviktor, for the PR.
I see value in integrating PHPStan as part of our CI, but we've been having issues as the plugin needs to be compatible with PHP 5.6.
For that reason, I'm closing this PR in favor of #391.
Perhaps you've some ideas on how to overcome the failed builds.
Author
Perhaps you've some ideas on how to overcome the failed builds.
Hello @pereirinha! CI should install PHPStan breaking PHP 5.6 compatibility.
As a new job: https://github.com/cloudinary/cloudinary_wordpress/blob/master/.travis.yml#L12
PHPStan is a modern, "non-WordPress" tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
@DavidCramer Done :) 🍏
as per Automattic/VIP-Coding-Standards#457