-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
@pereirinha
pereirinha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left you a few questions in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidCramer
Since we are changing the script variable name inside, from TermsOrder to something more abstract like ClassicEditor, perhaps we can find a more abstract slug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pereirinha - Good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still many references to jQuery in this script.
Can't we remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pereirinha Oops, I messed some 🤦 - forgot about the jQuery over the $
No description provided.