Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Add --retry-all-errors option when downloading Go binary#868

Open
ivanovac wants to merge 1 commit intomaster from
add-retry-all-errors
Open

Add --retry-all-errors option when downloading Go binary #868
ivanovac wants to merge 1 commit intomaster from
add-retry-all-errors

Conversation

@ivanovac
Copy link
Contributor

@ivanovac ivanovac commented Jan 21, 2026
edited
Loading

Add --retry-all-errors option when downloading Go binary

Summary

Added the --retry-all-errors flag to the curl command that downloads the Go binary in install_go.sh

Problem

The current implementation uses curl --retry 15 which only retries on specific transient errors (timeouts, 5xx responses). However, it does not retry on other errors such as:

Solution

Adding --retry-all-errors makes curl retry on any error response, not just the default set. This significantly improves resilience when downloading from the well-known and trusted URL https://buildpacks.cloudfoundry.org/dependencies/go.

Benefits

More reliable builds in environments with intermittent network connectivity
Reduces false-positive build failures due to transient network issues
No breaking changes - the download still validates SHA256 checksum after successful retrieval

Testing

The change maintains existing behavior for successful downloads while adding retry capability for previously non-retryable errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /