Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make mysqlclient an optional dependency #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
willprice wants to merge 4 commits into clips:master
base: master
Choose a base branch
Loading
from uob-vil:master

Conversation

@willprice
Copy link

@willprice willprice commented Nov 17, 2018

MySQL shouldn't be a core dependency, I've moved it to an extra package which can be installed as pip install pattern[mysql] if users wish to install with mysql support.

gutomaia, nacmartin, kylemcdonald, gattilorenz, johann-petrak, emettely, bblanchon, Jiaxin-Wen, PLPeeters, cristoper, and 10 more reacted with thumbs up emoji
Copy link

coveralls commented Nov 17, 2018
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 67.472% when pulling 3b77852 on uob-vil:master into 5b85d99 on clips:master.

Copy link

+1

1 similar comment
Copy link

+1

Copy link

thank you. i tried to get pattern running on mac with this:

brew install mysql-client
pip3 install pattern

But I couldn't get it to work. This works though:

pip3 install git+https://github.com/uob-vil/pattern.git
ndvbd and BrandonStudio reacted with thumbs up emoji jnelson16, jifan-chen, emettely, kaigexie, schedutron, kumarmanas, ramsrib, and BrandonStudio reacted with hooray emoji

Copy link

tuky commented Nov 7, 2019

It would be awesome to see this happen! :-)

Copy link

Mysql really complicates the installation, as it turns out installing the myssqlclient on a windows machine is non trivial. Any luck on removing this dependency? I've linked some related issues which can all be closed when this is resolved.

blmoistawinde, frankier, and HRezaei reacted with thumbs up emoji

Copy link

ndvbd commented Dec 5, 2022

I get:

File "/usr/lib/python3.10/zipfile.py", line 1267, in init
self._RealGetContents()
File "/usr/lib/python3.10/zipfile.py", line 1334, in _RealGetContents
raise BadZipFile("File is not a zip file")
zipfile.BadZipFile: File is not a zip file

Copy link

@tom-de-smedt Can you please merge this or mark the GitHub project as Archived?

When will this issue be resolved?

kdmukai added a commit to readworks/pattern that referenced this pull request Aug 1, 2024
Apply upstream's PR clips#250 to "development" branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /