-
Notifications
You must be signed in to change notification settings - Fork 64
fixed issue #83 #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fixed issue #83 #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clearloop
clearloop
requested changes
Jul 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for you PR! but please keep the usage of test_flag, and do not use unwrap() inside the code
clearloop
clearloop
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #83
also fixed issue where the created test case file (.test.dat) was empty.
test command works now, but panics if the test fail.
error on failing:-
[INFO leetcode_cli::plugins::leetcode] Sending code to judge... thread 'main' panicked at 'submit succcessfully, parse question_id to i32 failed: ParseIntError { kind: Empty }', src/cache/models.rs:317:34 note: run with "RUST_BACKTRACE=1" environment variable to display a backtracecan't seem to figure out how to fix this.