Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow for custom testcases with the leetcode test command, and some minor edits #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clearloop merged 3 commits into clearloop:master from Raees678:master
Feb 29, 2020

Conversation

Copy link
Contributor

@Raees678 Raees678 commented Feb 29, 2020

Now allows for an optional command line argument after leetcode test so that a custom test case can be provided. Test cases provided can be multiline with a \n.

Adds to the .gitignore .DS_Store and .idea files. Now macOS trash files and CLion/Intellij IDE support files are ignored.

Also makes a slight visual change so that when test cases are displayed in the CLI a ↩ (newline) character is used instead of a , (comma) to signify multi line input test cases.

clearloop reacted with thumbs up emoji
Copy link
Owner

Thanks!!! I've already wanted to add test cases but forgot about it recently...


btw, Have you ever seen a lot of

warning: use of deprecated item 'std::error::Error::description': use the Display impl or to_string()

in the current version?

My rustc version is rustc 1.43.0-nightly (61d9231ff 2020年02月15日), and I'm not sure what will happen if I fix these warnings in my environment XD.

I'll merge this pr now, and will do some fix jobs on these warnings, then we can publish a new version as v0.2.15!

@clearloop clearloop merged commit b3086a5 into clearloop:master Feb 29, 2020
Copy link
Contributor Author

Raees678 commented Feb 29, 2020
edited
Loading

I see those warnings too (rustc 1.41.0 (5e1a79984 2020年01月27日), but didn't really want to try and investigate too much for fear of breaking the existing project. Thanks for the merge, this project has really streamlined my leetcode grinding so its nice to contribute to something I actually use!

Copy link
Owner

I'm really touched by your pr, bro!

Your pr is very meaningful to me! This is the first time that somebody else pull request to my project in my life, and it also means that I did write a project can be used by others!!! Anyway, I'll do whatever I can to improve this project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /