-
Notifications
You must be signed in to change notification settings - Fork 65
[Testsing] Adds test data files #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shmuga
shmuga
commented
May 11, 2021
pub struct MetaData {
pub name: Option<String>,
pub params: Option<Param>,
pub params: Option<Vec<Param>>,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This params option was failing in the latest version of the CLI, seems having it as Option<Vec< works fine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Catch! Fixed in 02f8d66 but forgot to push LOL
Scope: introduces a test data files that are created alongside with code files. Those files are pre-filled with sample tests from leetcode and could be extended with the custom values. CLI test input has always a priority over test files. If test file is missing and test input is not provided, sample test case is used as was previously. Changes: - Fixes a bug with missing Vec<> inside of optional - Adds runtime error message to the output - Generates a test file when test is created
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope: introduces a test data files that are created alongside with code
files. Those files are pre-filled with sample tests from leetcode and
could be extended with the custom values. CLI test input has always a
priority over test files. If test file is missing and test input is not
provided, sample test case is used as was previously.
Changes:
Fixes #26