-
Notifications
You must be signed in to change notification settings - Fork 65
Handle new added problems properly #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
@hulufei
hulufei
commented
Mar 24, 2020
- Fixed the cache can't update with new added problems
- Display user friendly errors when pick/edit new added problem.
Thanks!!!
Could the replace_into
insert new problems that not exist?
I just find some error, I'll check it again tonight and fix it, then we can upgrade a new version.
I just find some error, I'll check it again tonight and fix it, then we can upgrade a new version.
The error is not caused by this pr, the get_problems
function has some errors, if we run:
$ leetcode data --delete
$ leetcode list
lc will panic, and this is my fault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.