-
Notifications
You must be signed in to change notification settings - Fork 66
fix: shell detection message always outputed when generating completion #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmmm, I'm not entirely sure why the ci/cd build fails for macOS, it seems to work locally on my own system
Hmmm, I'm not entirely sure why the ci/cd build fails for macOS, it seems to work locally on my own system
nevermind, I'll fix it later
clearloop
clearloop
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the shell detection message is always outputed when generating shell completions, regardless of whether the user provided a shell or not. The issue is that the println() is always being executed when it is inside the closure provided to the
unwrap_or
, event when a valid shell is provided. I'm not familiar with rust, so I don't know why this is the case.More importantly though, even if the message is ouptuted correctly, it actually prevents the completion from detected correctly (at least for zsh) when added to a file in the fpath like so:
$ leetcode completions zsh >! /usr/local/share/zsh/site-functions/_leetcode
That line has to be manually deleted since it comes before
#compdef leetcode
For these reasons, I think it would be best to just not output it at all and include that info in the README.
If you would prefer to keep the detection message, the following snippet will correctly output the message at the end of the file, but is no where near as elegant.
Let me know what you think. Thanks.