-
Notifications
You must be signed in to change notification settings - Fork 65
Support picking question via name #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@clearloop
clearloop
force-pushed
the
master
branch
from
June 24, 2023 05:32
c1bf05e to
24e611e
Compare
hey @gotlougit! would you mind merging master and resolving the conflicts? imo the current PR is enough for merging!
@gotlougit
gotlougit
force-pushed
the
master
branch
from
June 25, 2023 15:28
90c3749 to
17fcf95
Compare
I noticed there was a different error while running cargo check, it seems unrelated to this PR.
clearloop
clearloop
approved these changes
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new flag to leetcode pick which allows users to select a question based on the question name. The question name has to be exactly the same, but given how it is sometimes easier to remember the question name rather than question number in Leetcode, this will still help in ease of use.
Eg.
leetcode pick --name "Two Sum"gets the Two Sum problem from LeetCode. If no name is present, it defaults to finding by ID as before.The rest of the subcommands are exactly the same since it is presumed that the user can just look at the question number from leetcode pick anyway.
README was also changed to reflect this new command type.