Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: list plan crash #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendajiang merged 6 commits into clearloop:master from wendajiang:master
Dec 14, 2022
Merged

fix: list plan crash #103

wendajiang merged 6 commits into clearloop:master from wendajiang:master
Dec 14, 2022

Conversation

Copy link
Collaborator

@wendajiang wendajiang commented Dec 12, 2022

list command if open pym feature, not replace value_of.

@wendajiang wendajiang requested review from clearloop and removed request for clearloop December 14, 2022 08:49
Copy link
Collaborator Author

@clearloop Unfortunately, as the reason collaborator can not merge PR :).
image

Copy link
Owner

clearloop commented Dec 14, 2022
edited
Loading

Even after all required reviewers have approved a pull request, collaborators cannot merge the pull request if there are other open pull requests that have a head branch pointing to the same commit with pending or rejected reviews. Someone with write permissions must approve or dismiss the blocking review on the other pull requests first.

you need to approve it first I believe ( at least 1 approval )

Copy link
Collaborator Author

Even after all required reviewers have approved a pull request, collaborators cannot merge the pull request if there are other open pull requests that have a head branch pointing to the same commit with pending or rejected reviews. Someone with write permissions must approve or dismiss the blocking review on the other pull requests first.

you need to approve it first I believe ( at least 1 approval )

I can not approve myself :)

@wendajiang wendajiang merged commit 930064f into clearloop:master Dec 14, 2022
Copy link
Contributor

Congee commented Dec 26, 2022

Hi, can this patch be released to crates.io?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clearloop clearloop clearloop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /