-
Notifications
You must be signed in to change notification settings - Fork 2.5k
tweak(mumble): reduce locking around GetTalkers #3729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AvarianKnight
wants to merge
1
commit into
citizenfx:master
from
AvarianKnight:tweak/mumble-reduce-locking
Open
tweak(mumble): reduce locking around GetTalkers #3729
AvarianKnight
wants to merge
1
commit into
citizenfx:master
from
AvarianKnight:tweak/mumble-reduce-locking
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `_isAnyoneTalking` gets called a decent bit in game code, and for some reason the code here iterates *the entire talker list* again, and this can presummably happen multiple times a frame and cause lock contention. Most of the work here is already handled by another call that happens per frame so we juse reuse `g_talkers` and `o_talkers`. - `GetTalkers` also did a bunch of un-needed locking on every `GetUser` call when it was trying to get users from their session id's, so we change how we expect data to be handed back down and add a new function to handle getting all of the user names and reduce the amount of locking/unlocking we do.
@github-actions
github-actions
bot
added
the
invalid
Requires changes before it's considered valid and can be (re)triaged
label
Nov 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Reduce locking around user list access
How is this PR achieving the goal
_isAnyoneTalkinggets called a decent bit in game code, and for some reason the code here iterates the entire talker list again, and this can presumably happen multiple times a frame and cause lock contention. Most of the work here is already handled by another call that happens per frame so we just reuseg_talkersando_talkers.GetTalkersalso did a bunch of un-needed locking on everyGetUsercall when it was trying to get users from their session id's, so we change how we expect data to be handed back down and add a new function to handle getting all of the user names and reduce the amount of locking/unlocking we do.This PR applies to the following area(s)
FiveM/RedM
Successfully tested on
Game builds: ..
Platforms: Windows, Linux
Checklist
Fixes issues