-
Notifications
You must be signed in to change notification settings - Fork 13
Add GitHub Actions CI to replace AppVeyor and fix build errors #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: chsword <274085+chsword@users.noreply.github.com>
Co-authored-by: chsword <274085+chsword@users.noreply.github.com>
...ons workflow Co-authored-by: chsword <274085+chsword@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR modernizes the CI/CD pipeline by replacing AppVeyor with GitHub Actions while fixing a critical build error that prevented compilation.
- Replaced outdated AppVeyor CI with a comprehensive GitHub Actions workflow supporting multiple .NET versions (6.0, 8.0, 9.0) and cross-platform testing
- Fixed syntax error in ExcelConstants.cs array initialization that prevented project compilation
- Updated CI badges in README files to reference the new GitHub Actions workflow
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| appveyor.yml | Removed outdated AppVeyor configuration |
| .github/workflows/dotnet-core.yml | Added modern GitHub Actions CI workflow with multi-framework and cross-platform support |
| Chsword.Excel2Object/Internal/ExcelConstants.cs | Fixed array initialization syntax error preventing compilation |
| README.md | Updated CI badge to reference GitHub Actions |
| README_EN.md | Updated CI badge to reference GitHub Actions |
| Chsword.Excel2Object.sln | Updated solution items to reference new GitHub Actions workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Overview
This PR adds a modern GitHub Actions CI workflow to replace the existing AppVeyor CI configuration, while also fixing critical build errors that prevented the project from compiling.
Changes
1. Fixed Build Error in ExcelConstants.cs
The project had a syntax error in the
CommonDateTimeFormatsarray initialization that prevented compilation:2. Updated GitHub Actions Workflow
Replaced the outdated
.github/workflows/dotnet-core.yml(which used .NET Core 3.1) with a comprehensive modern CI pipeline:Key improvements:
mainandmasterbranches3. Updated Documentation
README.md(Chinese) to reference GitHub Actions instead of AppVeyorREADME_EN.md(English) to reference GitHub Actions instead of AppVeyor4. Removed AppVeyor Configuration
appveyor.ymlas it's replaced by GitHub ActionsTest Results
✅ All 88 tests pass successfully
✅ Builds successfully for all target frameworks: netstandard2.0, net472, net6.0, netstandard2.1, net8.0, net9.0
✅ NuGet package generation verified
Migration Notes
The new GitHub Actions workflow provides better integration with the GitHub ecosystem and more comprehensive CI coverage than the previous AppVeyor setup. No action is required from contributors - the new CI will automatically run on all pull requests and pushes.
Original prompt
💬 Share your feedback on Copilot coding agent for the chance to win a 200ドル gift card! Click here to start the survey.