-
Notifications
You must be signed in to change notification settings - Fork 404
Conversation
Adds a note for a frequently encountered issue that will prevent users from being able to use a ClusterIssuer as suggested in the documentation. Solution comes from this issue comment: cert-manager/cert-manager#3246 (comment) Signed-off-by: Tobias Cohen <tobi@tobico.net>
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign inteon for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Details
Needs approval from an approver in each of these files:Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
hawksight
commented
Apr 10, 2025
Hello @tobico, thank you for contributing an enhancement to our documentation. I struggled to actually find the page when reviewing but finally found it. I have a couple of suggestions, but let me just suggest an alternate wording:
When cert-manager is installed using Helm, the CRDs are not included by default. Please refer to our [helm installation instructions](../installation/helm.md#2-install-cert-manager) for the correct input value to enable the CRDs during installation.
Mainly this was to:
- Not repeat the values flags in more pages as they need to be updated and will likely be forgotten in the future
- Point to existing instruction which has the right flag:
--set crds.enabled=true
If you are happy to update with something similar to above that'd be great. If not I can always make the change if you don't have time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CRD for Issuer is also not installed.
Adds a note for a frequently encountered issue that will prevent users from being able to use a ClusterIssuer as suggested in the documentation.
Solution comes from this issue comment: cert-manager/cert-manager#3246 (comment)