-
Notifications
You must be signed in to change notification settings - Fork 404
Conversation
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Jan-Philipp Litza <jplitza@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maelvls for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Details
Needs approval from an approver in each of these files:Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds guidance for handling ACME challenges that are in an "errored" state by documenting that it's safe to delete errored challenges, which will trigger cert-manager to create new ones and retry the process.
- Adds documentation explaining that errored challenges can be safely deleted for retry behavior
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Copilot
AI
Sep 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'State' should be lowercase as it refers to the status field rather than a proper noun.
I was looking for how to proceed if a Challenge is in "errored" state with the details pointing to a timeout. But all I could find in the troubleshooting guide (or really, The Internet) was what underlying problems could be in case Challenges or Orders are stuck in "pending". Thus, I deleted the Challenge, and a new one appeared. So maybe it should be mentioned that deleting Challenges is safe.