-
Notifications
You must be signed in to change notification settings - Fork 39
Open
Conversation
oed
oed
approved these changes
Apr 27, 2022
@oed
oed
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth calling out that it might be possible to run in browser, but that it has not been tested?
PaulLeCam
commented
Apr 27, 2022
Contributor
Author
Does it? I thought core or some of its dependencies rely on Node-specific APIs, no?
Anyways I don't think we should encourage anyone to run core in browser if we're not going to support it ourselves.
zachferland
force-pushed
the
main
branch
8 times, most recently
from
February 10, 2023 20:19
3ef43e4 to
48090da
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove misleading statement about core package running in browser.