-
-
Notifications
You must be signed in to change notification settings - Fork 49
Open
Conversation
@leso-kn
leso-kn
force-pushed
the
await-in-js-callbacks
branch
from
June 12, 2025 13:57
54a4529 to
d2fff00
Compare
Succubyss
commented
Nov 25, 2025
Could this perhaps be merged sometime soon?
yuri-kiss
commented
Jan 3, 2026
pls
RodrigoDornelles
RodrigoDornelles
suggested changes
Jan 4, 2026
@RodrigoDornelles
RodrigoDornelles
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need unit tests to ensure that.
@leso-kn
leso-kn
force-pushed
the
await-in-js-callbacks
branch
from
January 6, 2026 12:35
d2fff00 to
2b8eb50
Compare
leso-kn
commented
Jan 6, 2026
Author
@RodrigoDornelles Good call, unit tests added via 2b8eb50 :)
Drago-Cuven
commented
Jan 12, 2026
we absolutely need this
leso-kn
commented
Jan 12, 2026
Author
@Drago-Cuven If you need a feature early npm offers the possibility to install packages from git branches:
The code review depends on the availability / free-time of the wasmoon maintainers.
# in your project > npm i git+https://github.com/leso-kn/wasmoon#await-in-js-callbacks # or > git clone -b await-in-js-callbacks https://github.com/leso-kn/wasmoon > cd wasmoon && npm i > npm run build:wasm # or build:wasm:docker # then, in your project > npm i <path/to/cloned/wasmoon>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the limitation of awaiting promises in Lua functions that are called from Javascript.
Effect
If a Lua function is called from Javascript, it will still return the value returned by the Lua function. However, if the Lua function attempts to yield at any point, a Promise is instead returned to Javascript which either resolves to the return value of the Lua function once it completes or catches if a Lua error occurs.
Technical Explanation
The limitation was solved by calling the function thread via
lua_resume()instead oflua_pcallk()and then handing over the thread toThread.run()(which enables the usage of await) in the case that the returned result isLuaReturn.Yield.