-
Notifications
You must be signed in to change notification settings - Fork 83
For local builds always remove the platform folder and extract archive#119
Draft
amaitland wants to merge 1 commit into
Draft
For local builds always remove the platform folder and extract archive #119amaitland wants to merge 1 commit into
amaitland wants to merge 1 commit into
Conversation
@amaitland
amaitland
force-pushed
the
copylocalremovetargetfolder
branch
from
January 25, 2025 09:48
95b9b10 to
7822aec
Compare
amaitland
commented
Jan 25, 2025
Member
Author
@mol Apologies for the delay. If i understood correctly this is what you were proposing?
mol
commented
Jan 28, 2025
@mol Apologies for the delay. If i understood correctly this is what you were proposing?
No worries. Yeah, for the part where the locally copied archive is extracted, but the local archive I think should also always be replaced (otherwise it's just extracting the same archive again and again). So this if I would also remove.
So it always:
- Replaces any local archive.
- Extracts from that local archive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using locally built folders then always remove the platform folder and extract the archive.