-
Notifications
You must be signed in to change notification settings - Fork 6
Swap to using audiotags for better compatibility#78
Open
Ralim wants to merge 5 commits intocdown:master from
Open
Swap to using audiotags for better compatibility #78Ralim wants to merge 5 commits intocdown:master from
Ralim wants to merge 5 commits intocdown:master from
Conversation
Owner
cdown
commented
Jul 25, 2023
Hey! I actually added comment support to audiotags in preparation for this a few months ago, but there has been no release since: TianyiShi2001/audiotags@b6b3df1
So the first step would be to have them do a release. Thanks for looking at this! :-)
Author
Ralim
commented
Jul 25, 2023
Ah well then that would be excellent.
Should you/me/both of us ask for a release over there?
Happy to update this once we get a release 😁
Owner
cdown
commented
Dec 2, 2023
Looks like a release is close: TianyiShi2001/audiotags#40
pinkforest
commented
Feb 22, 2024
fyi the release happened
Bide-UK
commented
Jun 12, 2024
bump also want to use this one flac
Author
Ralim
commented
Jul 25, 2024
I've updated the PR to use the latest audiotags release and comments.
@cdown Would appreciate a review when you have time
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋🏼 ,
I wanted to use this on
FLACfiles and it didnt yet work.I've done this base pass conversion over to
audiotags. It seems to work nicely for me here.However audiotags doesnt support the
commentfield so not sure how to handle the filter forfixer_is_blacklisted.Would love your comments on how you would prefer to move forward for using it.
Looking in the trait
AudioTagEdit; there is no nicely exposed option for us to use.Would close #36