-
Notifications
You must be signed in to change notification settings - Fork 3
Comments & organization of app code#20
Comments & organization of app code #20diazrenata wants to merge 13 commits intocct-datascience:main from
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be more useful to change this logic to read in the real location file Lat_long_AFSshiny_012023.csv, then if that's not available to read in the toy one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switched!
KristinaRiemer
commented
Sep 19, 2023
Other than my one comment about reading in location data, I think this looks good! Having all of these comments and structure is super useful. I am going to wait until you implement that change @diazrenata and then I'll test the code locally to make sure everything works and merge this.
...you have to switch it). Also fix typo in ggplot on line 730 and remove review_notes.md from what would get merged upstream.
diazrenata
commented
Sep 21, 2023
@KristinaRiemer I toggled the toy_locs data and resolved the merge conflicts (mostly related to whitespace/indentation). I also fixed the typo referenced in #18, so that PR is no longer needed. This should be ready for you to test!
See diazrenata#1