-
Notifications
You must be signed in to change notification settings - Fork 483
Accelerate DynamicProxy test execution #726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in `ParameterDefaultValuesTestCase`. This should drastically accel- erate test execution time for this large fixture.
Member
Author
stakx
commented
Jan 7, 2026
Interestingly, while these changes drastically reduce test execution time on my local machine (by nearly 11⁄2 minutes), they hardly appear to affect our CI builds at all. So perhaps there's not much point going ahead with this, better to wait for the bigger "to BasePEVerifyTestCase or not to BasePEVerifyTestCase" review? I'll sleep on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Test execution has got much slower ever since I introduced a large number of test cases in
ParameterDefaultValuesTestCase. The situation can easily be improved, since the slow-down is largely due to a higher number ofpeverify.exeinvocations. Most of these aren't actually necessary, since it is the same proxy type getting generated for each test case.We could either split the test fixture in two – with only one deriving from
BasePEVerifyTestCaseand getting the tests where PEVerify should be run – or we could come up with a way to skippeverify.exefor single tests. For now, I am opting for the latter solution.I am aware that this is something of a quick fix. In the long run, it would probably make more sense to review all tests and decide which really need to be in a
BasePEVerifyTestCase-derived fixture, and which ones don't really require any IL verification. Such a review will take much more time, I'm holding that off for the moment.