Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Accelerate DynamicProxy test execution #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
stakx wants to merge 2 commits into castleproject:master
base: master
Choose a base branch
Loading
from stakx:test-execution-speed

Conversation

@stakx
Copy link
Member

@stakx stakx commented Jan 7, 2026
edited
Loading

Test execution has got much slower ever since I introduced a large number of test cases in ParameterDefaultValuesTestCase. The situation can easily be improved, since the slow-down is largely due to a higher number of peverify.exe invocations. Most of these aren't actually necessary, since it is the same proxy type getting generated for each test case.

We could either split the test fixture in two – with only one deriving from BasePEVerifyTestCase and getting the tests where PEVerify should be run – or we could come up with a way to skip peverify.exe for single tests. For now, I am opting for the latter solution.

I am aware that this is something of a quick fix. In the long run, it would probably make more sense to review all tests and decide which really need to be in a BasePEVerifyTestCase-derived fixture, and which ones don't really require any IL verification. Such a review will take much more time, I'm holding that off for the moment.

stakx added 2 commits January 7, 2026 02:47
... in `ParameterDefaultValuesTestCase`. This should drastically accel-
erate test execution time for this large fixture.
Copy link
Member Author

stakx commented Jan 7, 2026

Interestingly, while these changes drastically reduce test execution time on my local machine (by nearly 11⁄2 minutes), they hardly appear to affect our CI builds at all. So perhaps there's not much point going ahead with this, better to wait for the bigger "to BasePEVerifyTestCase or not to BasePEVerifyTestCase" review? I'll sleep on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /