-
Notifications
You must be signed in to change notification settings - Fork 221
Comments
Fix debian package generation to include subdirectories#567
Open
civerachb-cpr wants to merge 2 commits intocanopen-python:master from
Open
Fix debian package generation to include subdirectories #567civerachb-cpr wants to merge 2 commits intocanopen-python:master from
civerachb-cpr wants to merge 2 commits intocanopen-python:master from
Conversation
...nd to create the debian package
Member
Thanks for your contribution and for trying to improve the Debian package generation.
I don't think we want to proliferate stuff in setup.py. The package has already adopted a more modern approach based on the declarative pyproject.toml file. I have no experience with how Debian usually handles building Python packages, but I doubt that adding stuff to setup.py is state of the art. Of course, neither is an elaborate makedeb script including logic to extract the version string, so there is definitely room for improvment.
Building the package by itself should be left to the PyPA build helper: python3 -m build in the distro's top level directory. Or utilize the common Debian Python package build helpers, such as pybuild.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing .deb generation does not include subdirectories, resulting in missing modules:
image
makedebintosetup.pyas parameterspython3 setup.py --command-packages=stdeb.command bdist_debTested on Ubuntu 24.04; resulting debian file now includes the missing folders (see screenshot above)