This repository was archived by the owner on Jan 14, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 23
Open
Conversation
prscX
commented
Mar 2, 2018
Author
Hi @chase-calm, I have also changed delegate from weak type to strong:
@property (nonatomic, weak) id<SexyTooltipDelegate> delegate;
TO
@property (nonatomic, strong) id<SexyTooltipDelegate> delegate;
Reason: I have tried registering delegate for callback's but NSTimer somehow was removing the registered delegate.
Can you please merge the raise PR. Please let me know in case any discussion is required for the same.
Thanks
Pranav
prscX
commented
Mar 21, 2018
Author
Hi @tsheaff, Can you please merge this PR.
Thanks
Pranav
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @chase-calm
First of all I would like to appreciate for creating such a nice, cool library
I have created a React Native bridge plugin for using this library with React Native projects
I have added the same in README. Can you please merge this request so that if someone is looking to use this library for React Native projects can easily do the same
Please let me know in case any changes are required
react-native-tooltips
Thanks
Pranav