Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: add launch landing site#686

Open
thymikee wants to merge 17 commits into
main from
landing-launch
Open

feat: add launch landing site #686
thymikee wants to merge 17 commits into
main from
landing-launch

Conversation

@thymikee

@thymikee thymikee commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Adds the new landing Next.js site for the public agent-device.dev launch, rebased onto latest main.

Adds the missing GitHub header link with a server-rendered live star counter cached for 4 hours.

Touched file count: 87. Scope is limited to the landing app.

Validation

Ran pnpm lint, pnpm audit:assets, pnpm build, and LANDING_SMOKE_URL=http://localhost:4312 pnpm smoke:browser. Browser smoke passed for 3 pages across 3 viewports.

github-actions Bot commented Jun 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 1.2 MB 1.1 MB -51.5 kB
JS gzip 385.4 kB 367.5 kB -17.9 kB
npm tarball 497.3 kB 473.5 kB -23.8 kB
npm unpacked 1.7 MB 1.6 MB -89.8 kB

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 29.0 ms 27.9 ms -1.1 ms
CLI --help 45.2 ms 43.3 ms -1.9 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/record-trace.js +31.4 kB +10.0 kB
dist/src/9533.js +30.7 kB +9.2 kB
dist/src/cli.js +25.6 kB +9.2 kB
dist/src/2415.js -15.9 kB -4.6 kB
dist/src/command-metadata.js +9.4 kB +3.7 kB

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026年06月03日 21:00 UTC

@thymikee thymikee left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: launch landing site

Reviewed the dynamic/data-flow surface (the static content + assets I skimmed only). Focused on perf, data flow, and API usage per the review criteria. Overall the server/client boundary is clean. Notes, all low-severity:

What works well

  • Resilient GitHub stats flow. getGitHubRepoStats uses next: { revalidate: 4h } for ISR caching, attaches GITHUB_TOKEN when present (avoids unauthenticated rate limits), and degrades gracefully to null → GitHubStarLinkFallback. The repo slug callstackincubator/agent-device matches the canonical one in README.md/package.json, so the counter resolves. Good defensive design.
  • Accessible, well-behaved carousel. hero-agent-carousel.tsx pauses on hover/focus/visibilitychange, honors prefers-reduced-motion, and drives everything through refs so the useCallbacks stay stable without stale-closure bugs. Nicely done.

Worth considering

  • Clipboard API ordering (prompt-copy-button.tsx). The primary path is the deprecated document.execCommand("copy"), with navigator.clipboard.writeText only as the fallback when that returns false. This is inverted from current best practice — the async Clipboard API is the standard and should be tried first, with execCommand as the legacy fallback. It works today, but it leads with a deprecated API.
  • force-dynamic on static text routes. llms.txt and llms-full.txt set export const dynamic = "force-dynamic", but createLlmsTxt()/createLlmsFullTxt() are build-time-constant. This opts the routes out of static optimization so each origin request recomputes them (mitigated by the manual Cache-Control + CDN). If the content is truly static, dropping force-dynamic (or force-static) lets Next serve them as static assets.
  • Nit — OG image fonts. og-image.tsx renders with system monospace/default sans rather than the bundled Alliance/Switzer brand fonts. Purely cosmetic; flagging only since the brand fonts are already in the bundle.

Noting this PR is already closed — happy to move these onto whichever PR carries the landing site forward if that's more useful.

Generated by Claude Code

Copy link
Copy Markdown
Member Author

Landing preview automation is now wired via .github/workflows/landing-preview.yml and triggered on this reopened PR. Evidence: the new Deploy Landing Preview check appeared on PR #686 after reopening. It currently fails at Verify Vercel token because no VERCEL_TOKEN repository secret is available to Actions. Add a Vercel token secret for the linked landing/.vercel/project.json project and rerun the workflow to produce the preview URL comment.

Copy link
Copy Markdown
Member Author

Code review

Verdict: minor issues — clean, well-built marketing site; one broken CTA and a couple of content nits.

Findings

  1. Major — landing/src/components/stack-support-section.tsx:19: the "Book consultation" button links to href="#demo", but #demo is the id of the very section the button sits in (SectionShell id="demo" at line 9), so clicking this lead-gen CTA does nothing. The equivalent CTAs on product pages (product-page.tsx:283) correctly link to the Callstack contact form — the "link demo cta to contact form" commit evidently missed this one.

  2. Minor — landing/src/components/home/footer.tsx:15-17: in the "Documentation" footer group, both the "Documentation" and "GitHub" links point to the same GitHub repo URL, making the Documentation link redundant given the project has a docs site.

  3. Minor — landing/src/app/fonts/AllianceNo2-*.ttf: four files of the commercial Alliance No.2 typeface (~355 KB) are committed to a public OSS repo; worth confirming the license permits public redistribution of the raw font files (Switzer/Geist are fine).

Checked and solid

  • GitHub star counter (landing/src/lib/github.ts): returns null on any failure, 4h next.revalidate set correctly, token only from process.env.GITHUB_TOKEN, and the consumer degrades to a "Stars" label via Suspense — a GitHub outage/rate-limit can't break the page.
  • List keys: all .map() renderings use stable content-based keys; no remaining index-key hazards.
  • Internal links/anchors: all resolve except #demo (finding 1).
  • CI workflow (landing-preview.yml): fork-PR guard, pinned action SHAs, secrets handled properly.
  • Workspace isolation: landing/ is a fully isolated pnpm workspace (own pnpm-workspace.yaml + lockfile), so the main package build and CI are unaffected.
  • No secrets in the diff; assets are all webp/svg, largest 107 KB; a11y/SEO (aria-labels, roving tabindex, reduced-motion, metadata/OG/sitemap/JSON-LD) are in good shape.

Overall

Fix the self-referencing #demo anchor and this is good to merge.

Generated by Claude Code

Copy link
Copy Markdown
Member Author

Addressed the actionable PR feedback in commit 19b54c259.

Before -> after evidence:

  • Prompt copy tried execCommand first -> now uses async Clipboard API first, with legacy textarea fallback.
  • /llms.txt and /llms-full.txt were forced dynamic -> now force-static; local build reports both routes as static.
  • OG images used default/monospace text -> now load the bundled Alliance brand font in ImageResponse.
  • "Book consultation" pointed at #demo -> now points to the Callstack contact form.
  • Footer "Documentation" pointed at GitHub -> now points to the docs site.

Validation:

  • pnpm lint
  • pnpm build
  • LANDING_SMOKE_URL=http://127.0.0.1:4312 pnpm smoke:browser

Notes:

  • Alliance font license/redistribution still needs owner confirmation; that is not verifiable from code.
  • Vercel preview automation retriggered and is currently pending. Earlier preview run was blocked by the missing repo VERCEL_TOKEN secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /