-
Notifications
You must be signed in to change notification settings - Fork 92
Open
Conversation
andifreed
commented
Mar 10, 2021
Does that break ES5 support?
9 tasks
rtritto
commented
Sep 28, 2022
Any update?
rtritto
commented
Feb 24, 2023
@caldwell please can you merge this?
caldwell
commented
Feb 27, 2023
Owner
Not as it stands, no. When try it on the test.html page I get this error:
Uncaught SyntaxError: export declarations may only appear at top level of a module
I'm not opposed to Ecmascript modules at all, but right this second I don't know how to make something compatible with commonjs and modules and just raw <script> sourcing in html.
Probably the right answer in 2023 is to just make it a module, and use esbuild or something to make the non-module version/minimized versions when prepping for npm publish...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Added ES6 export, can be used like:
import renderjson from 'renderjson