-
Notifications
You must be signed in to change notification settings - Fork 92
Open
Conversation
bower is old now - its own website tells you to use yarn
(docstrings get picked up by intellisense)
Almenon
commented
Dec 7, 2019
Contributor
Author
WIP = work in progress (don't merge yet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts renderjson to typescript. Typescript has a number of benefits like type safety, catching common mistakes, easier refactoring, and better intellisense.
It also adds tests to make sure things are still working.
Make sure to run
prePublishbefore publishing a new version.Although theoretically backwards compatible, this is a major change so I've updated the version number to v2 just to be safe.
Unfortunately I just realized it doesn't work in the browser because of the use of "exports".... crap
Why is the JS ecosystem so complicated?? 😭