-
Notifications
You must be signed in to change notification settings - Fork 28
Add ability to save context to streams #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the ability to save an api context to a stream, rather than a files.
@pjvds thanks for this PR, did you read https://raw.githubusercontent.com/bunq/sdk_csharp/develop/.github/PULL_REQUEST_TEMPLATE.md ?
Could you please explain this change in an issue and rebase your commits to link to this issue. Your commit message should pass the following regex:
Line 4 in f48a242
- '([A-Za-z0-9 ]+)\. (\(bunq\/sdk_csharp#[0-9]+\))'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to save an api context to a stream, rather than a file. This makes the save more flexible and removes the dependency to the file system for saving and loading contexts.
The pull requests comes with extra unit tests ✅