Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Comments

Change all the missing colors to match the CPK colors used in jmol#15

Open
iribirii wants to merge 1 commit intobriling:master from
iribirii:master
Open

Change all the missing colors to match the CPK colors used in jmol #15
iribirii wants to merge 1 commit intobriling:master from
iribirii:master

Conversation

@iribirii
Copy link
Contributor

@iribirii iribirii commented Sep 10, 2025

No description provided.

Copy link
Owner

briling commented Sep 10, 2025

Hmm I don't know, in my mind most metals are kinda gray... Also a bit weird difference between La and Ce, is it supposed to be like that?

Copy link
Contributor Author

The colors are taken from the CPK colors 🤷‍♂️ (https://sciencenotes.org/molecule-atom-colors-cpk-colors/)

that is the color code used by jmol and other visualisation software. But there are plenty of color palettes, I just selected that cause is the one I'm most used to

image

Copy link

Could this be an optional flag or something? The same could be applied to colours in xyz2svg too - since cpk are fairly standardised having a --cpk flag could be useful in either/both

iribirii reacted with heart emoji

Copy link
Contributor Author

True I didn't think about xyz2svg, I should apply it there too 💀 at least in my fork hehe

Copy link
Owner

briling commented Oct 17, 2025

Thanks @iribirii @aligfellow ! I'll add is as an option

and thank you @aligfellow for the PRs for xyz2svg, I'll merge over the weekend/next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /