-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Deprecations #3510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Deprecations #3510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The deprecations seem reasonable!
Co-authored-by: Charmander <~@charmander.me>
Deploying node-postgres with Cloudflare Pages Cloudflare Pages
Latest commit:
26b5a94
Status: ✅ Deploy successful!
Preview URL:
https://ad8de443.node-postgres.pages.dev
Branch Preview URL:
https://bmc-deprecations.node-postgres.pages.dev
Thank you, as always, for your tireless & thoughtless contributions @charmander. If you ever make it to Ausitn TX, lemme know I'd love to take you out to dinner or getcha a gift card to H.E.B. :)
(i pressed wrong button)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client.activeQuery- the concept needs to be overhauled a bit to support pipeline mode in which multiple queries can be "in flight" at onceclient.queryQueue- this should never been manipulated from outside the client, and again will be changing with a pipeline mode implementation. The entire concept of "queueing" queries is very old, and honestly was a bad idea when I implemented it 15 years ago or however long ago it was. Lets just all pretend this doesn't exist and make it "private" so its more of an implementation detail.pgpasssupport - I'd rather this be done in userspace since the connection parameters can now take any old async function as the value to password, if someone's usingpgpassthey can install it & write a 1 liner in their connection config to use their file. I'm not 100% sold on this deprecation & removal being the best...but I also don't love having 3rd party dependencies for stuff like this. Interested in feedback here.