Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix #3508 - recheck min client count during idle callback #3509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianc merged 1 commit into brianc:master from barryhagan:master
Jul 10, 2025

Conversation

Copy link
Contributor

@barryhagan barryhagan commented Jul 10, 2025

No description provided.

Copy link
Owner

brianc commented Jul 10, 2025

wow! amazing turn around on this! thank you! ❤️

Copy link
Owner

brianc commented Jul 10, 2025

unrelated side note: I should port the test to use async/await now that it exists instead of using co. I used co because way way back async/await wasn't a thing, but writing callbacks was always icky.

@brianc brianc merged commit 01fadd9 into brianc:master Jul 10, 2025
7 checks passed
Copy link
Contributor

sehrope commented Jul 17, 2025

I used co because way way back async/await wasn't a thing, but writing callbacks was always icky.

Async / await?! Ha, we didn't even have native Promises!

charmander reacted with laugh emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /