-
-
Notifications
You must be signed in to change notification settings - Fork 60
Open
Conversation
bowbahdoe
commented
Oct 3, 2025
Owner
Not ignoring this or anything else; just busy with day job work. Will go through and handle other feedback shortly.
Maia-Everett
commented
Oct 3, 2025
Contributor
Author
No rush, take all the time you need!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rewrites the Unicode section to briefly explain what Unicode and UTF-16 are, and why working with individual
charvalues rather than whole strings is usually a bad idea.