Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add move_while and move_until new algorithms #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denzor200 wants to merge 3 commits into boostorg:develop
base: develop
Choose a base branch
Loading
from denzor200:move_if

Conversation

@denzor200
Copy link
Contributor

@denzor200 denzor200 commented Oct 17, 2022

Hello, i have an interest to be contributor of this library. I decided to start with this small PR to get experience and to receive feedback and "ping response" from community.

Copy link
Contributor Author

CI is broken, so this PR tested here: https://godbolt.org/z/b4vGMnK55

Copy link
Contributor

jgopel commented Oct 24, 2022

question: Forgive my ignorance - why not just use a std::move_iterator? What does this accomplish that that doesn't already do?

Copy link
Contributor Author

why not just use a std::move_iterator?

I had same question for std::move, but it exists. Look:

std::move(v.begin(), v.end(), std::back_inserter(l));

does the same result as:

std::copy(std::make_move_iterator(v.begin()),
 std::make_move_iterator(v.end()),
 std::back_inserter(l));

What does this accomplish that that doesn't already do?

just readability, and those people who use boost::algorithm::copy_while and boost::algorithm::copy_until also need for move_while and move_until.

jgopel reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /