-
Notifications
You must be signed in to change notification settings - Fork 99
Conversation
PR Summary
-
Updated Tooling Versions
The versions of development toolscdktfandcdktf-clihave been upgraded. The process of ensuring our code is up-to-date and fully supported can lead to improved performance, security, and error resolution. -
Upgraded Azure Provider Packages
The versions of Azure-related packages@cdktf/provider-azurermand@cdktf/provider-timehave been updated. This means our infrastructure-as-code will take advantage of the latest features and improvements in Azure services. -
Updated Node Version
The version requirement ofnodehas been tweaked for a couple of packages. With this minor update, we ensure the stability and compatibility with the latest version of Node.js.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a requirement of the new CDK version? Otherwise, I'd leave it as 18.0.0 in order to be less restrictive for end users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiertoledo yes, it seems to be a requirement for the new cdk tf version, see here. If it presents an issue, we can go back to version 0.17 I believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha, no objections then!
# Conflicts: # common/config/rush/pnpm-lock.yaml
javiertoledo
commented
Oct 30, 2023
/integration sha=4fc7a593c0f67fb95cded6defbb905c8e2b00c0b
|
Oops, looks like you forgot to add a changeset.
This command will prompt you for a change description and generate a changeset file. You can read more about changesets here. Remember that you should use the version bump that is appropriate for the change you are making:
If you are unsure about which version bump to use, please ask in the comments and we will help you out. |
❌ Oh no! Integration tests have failed
javiertoledo
commented
Oct 30, 2023
It seems that the Azure deployment failed. Maybe there's an API change that needs to be tweaked?
1) "before all" hook in "***root***":
Error: the string "npm\n WARN exec The following package was not found and will be installed: cdktf-cli@0.19.0\n\nError: terraform init failed with exit code 1\n\n\"Deployment of application my-store-4fc7a59 failed. Check cdktf logs. \\nundefined***\"\n Error: \"Deployment of application my-store-4fc7a59 failed. Check cdktf \n logs. \\nundefined***\"\n (You can see the full error logs in ./errors.log)\n" was thrown, throw an Error :)
at thrown2Error (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/mocha@10.2.0/node_modules/mocha/lib/runner.js:1241:10)
at Runner.fail (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/mocha@10.2.0/node_modules/mocha/lib/runner.js:443:11)
at cbHookRun (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/mocha@10.2.0/node_modules/mocha/lib/runner.js:532:14)
at done (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/mocha@10.2.0/node_modules/mocha/lib/runnable.js:310:5)
at /home/runner/work/booster/booster/common/temp/node_modules/.pnpm/mocha@10.2.0/node_modules/mocha/lib/runnable.js:377:11
at processTicksAndRejections (node:internal/process/task_queues:95:5)
samueldominguez
commented
Oct 31, 2023
It seems that the Azure deployment failed. Maybe there's an API change that needs to be tweaked?
1) "before all" hook in "***root***": Error: the string "npm\n WARN exec The following package was not found and will be installed: cdktf-cli@0.19.0\n\nError: terraform init failed with exit code 1\n\n\"Deployment of application my-store-4fc7a59 failed. Check cdktf logs. \\nundefined***\"\n Error: \"Deployment of application my-store-4fc7a59 failed. Check cdktf \n logs. \\nundefined***\"\n (You can see the full error logs in ./errors.log)\n" was thrown, throw an Error :) at thrown2Error (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/mocha@10.2.0/node_modules/mocha/lib/runner.js:1241:10) at Runner.fail (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/mocha@10.2.0/node_modules/mocha/lib/runner.js:443:11) at cbHookRun (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/mocha@10.2.0/node_modules/mocha/lib/runner.js:532:14) at done (/home/runner/work/booster/booster/common/temp/node_modules/.pnpm/mocha@10.2.0/node_modules/mocha/lib/runnable.js:310:5) at /home/runner/work/booster/booster/common/temp/node_modules/.pnpm/mocha@10.2.0/node_modules/mocha/lib/runnable.js:377:11 at processTicksAndRejections (node:internal/process/task_queues:95:5)
I suspect it might have to do with rush running the build on 18.18, I've updated it to 18.20, hopefully that fixes it @javiertoledo
samueldominguez
commented
Oct 31, 2023
Actually that broke it! Looking at it again.
samueldominguez
commented
Nov 10, 2023
@javiertoledo I think we can try running integration tests now
Description
Upgrade CDK TF to latest version
Changes
cdktf,cdktf-cli,@cdktf/provider-azurermand@cdktf/provider-timeto the latest version>=18.12.0 < 19.0.0wherevercdktf*packages are usedChecks
Additional information
If it's an issue moving to node
>=18.12.0 <19.0.0then wen move back to cdktf versions 18.x