-
Notifications
You must be signed in to change notification settings - Fork 99
Conversation
PR Summary
- Inclusion of Source Map
The configuration file for our TypeScript project was updated to generate source maps. This allows us to trace back any errors or bugs to the original source code, enhancing the debugging process and overall maintainability of the project.
👇 Click on the image for a new way to code review
Review these changes using an interactive CodeSee Map
Legend
CodeSee Map legend
@NickSeagull
NickSeagull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is meant to be added to the project template not the Booster tsconfig 😅
ironspec07
commented
Oct 12, 2023
Sorry 😅, I am kinda new to open source contributions.
ironspec07
commented
Oct 12, 2023
Thanks for the suggestion. @NickSeagull
@NickSeagull
NickSeagull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Let's see if the tests pass! 👏
NickSeagull
commented
Oct 12, 2023
/integration sha=8b29da3
⌛ Integration tests are running...
Check their status here 👈
❌ Oh no! Integration tests have failed
NickSeagull
commented
Oct 16, 2023
Hey @ironspec07 can you edit the integration test at packages/framework-integration-tests/integration/provider-unaware/cli/cli.project.integration.ts:358:15 so it checks for the existence of the sourceMap field?
It is failing in the integration tests: https://github.com/boostercloud/booster/actions/runs/6497419214/job/17646575081#step:3:720
Uh oh!
There was an error while loading. Please reload this page.
Description
Added sourceMap: true to the tsconfig.json of the new project which allows users to debug from VSCode easily by pressing F5
Changes
Added "sourceMap" : true to tsconfig.json
Checks