Skip to content

Navigation Menu

Sign in
Sign up

configured load tests for azure - #1057

Open
rdiaz82 wants to merge 6 commits into
main from
rdiaz82/features/load_test_azure
Open

configured load tests for azure #1057
rdiaz82 wants to merge 6 commits into
main from
rdiaz82/features/load_test_azure

Conversation

@rdiaz82

@rdiaz82 rdiaz82 commented Apr 12, 2022 •
edited
Loading

Copy link
Copy Markdown

Description

In this PR we are configuring the load tests for the Azure provider. Basically we have reverted serverless framework to the old version because it is not compatible with Serverless Artillery and then we have had to increase the timeout in the tests and adapted the load to be manageable by Azure. We achieve 200 requests/sec during 10 sec followed by 400 req/sec for 10sec.

Changes

  • Test configuration to be similar to other integration tests
  • modified timeouts in tests
  • Adapted the load to Azure

Checks

  • Project Builds
  • Project passes tests and checks
  • Updated documentation accordingly

rdiaz82 requested a review from a team April 12, 2022 13:22

@javiertoledo javiertoledo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very useful!

Comment on lines 48 to 49
"serverless": "1.83.3",
"serverless-artillery": "0.5.2",

@javiertoledo javiertoledo Apr 18, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So bad we're still relying on this, as this package has been abandoned. Just as a reminder for ourselves, there's a pending issue related to finding an alternative or building this capability within Booster #934

"integration/azure-end-to-end": "TESTED_PROVIDER=AZURE BOOSTER_ENV=azure mocha --forbid-only --exit --config \"integration/provider-unaware/end-to-end/.mocharc.yml\" \"integration/provider-unaware/end-to-end/**/*.integration.ts\"",
"integration/azure-func": "TESTED_PROVIDER=AZURE BOOSTER_ENV=azure mocha --forbid-only --exit --config \"integration/provider-unaware/end-to-end/.mocharc.yml\" \"integration/provider-unaware/functionality/**/*.integration.ts\""
"integration/azure-func": "TESTED_PROVIDER=AZURE BOOSTER_ENV=azure mocha --forbid-only --exit --config \"integration/provider-unaware/end-to-end/.mocharc.yml\" \"integration/provider-unaware/functionality/**/*.integration.ts\"",
"integration/azure-load": "TESTED_PROVIDER=AZURE AWS_SDK_LOAD_CONFIG=true BOOSTER_ENV=azure mocha --forbid-only --exit --config \"integration/provider-unaware/load/.mocharc.yml\" \"integration/provider-unaware/load/**/*.load.ts\""

@gonzalogarciajaubert gonzalogarciajaubert Apr 21, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this call on the "integration/azure" script (line 85)?

 

..._test_azure
# Conflicts:
#	package-lock.json
#	packages/framework-integration-tests/package.json

ghost commented Mar 2, 2023 •
edited by ghost
Loading

Copy link
Copy Markdown

Copy link
Copy Markdown
Member

/integration sha=792b5d6bf320704a207d5acc1ef92b1cf2284cac
github-actions[bot] reacted with rocket emoji github-actions[bot] reacted with eyes emoji

github-actions Bot commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

⌛ Integration tests are running...

Check their status here 👈

github-actions Bot commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

❌ Oh no! Integration tests have failed

javiertoledo reacted with confused emoji

Copy link
Copy Markdown
Member

/integration sha=f7a32b7d18aaa1b7d0c961433089a3edcd42fb26
github-actions[bot] reacted with rocket emoji github-actions[bot] reacted with eyes emoji

github-actions Bot commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

⌛ Integration tests are running...

Check their status here 👈

github-actions Bot commented Mar 2, 2023

Copy link
Copy Markdown
Contributor

❌ Oh no! Integration tests have failed 

..._test_azure
# Conflicts:
#	common/config/rush/pnpm-lock.yaml

Copy link
Copy Markdown
Member

/integration sha=3e61b829586e58a7c565b7c83ed144ee0d7fdd6a
github-actions[bot] reacted with rocket emoji github-actions[bot] reacted with eyes emoji

github-actions Bot commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

⌛ Integration tests are running...

Check their status here 👈

github-actions Bot commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

❌ Oh no! Integration tests have failed

2 similar comments

github-actions Bot commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

❌ Oh no! Integration tests have failed

github-actions Bot commented Oct 3, 2023

Copy link
Copy Markdown
Contributor

❌ Oh no! Integration tests have failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiertoledo javiertoledo javiertoledo approved these changes
+2 more reviewers
@gonzalogarciajaubert gonzalogarciajaubert gonzalogarciajaubert left review comments
@NickSeagull NickSeagull NickSeagull approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /