-
-
Notifications
You must be signed in to change notification settings - Fork 501
refactor ArrayList tests changes #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erneman1 very nice overall! 💪
Just a couple of minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erneman1 please remove this line. All private methods are considered as helper methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erneman1 I would rather remove these blank lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erneman1 why don't you want to use @SneakyThrows? Please add it to these helper methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erneman1 I guess it will be clearer when we first get the array and then do all assertions. Since calling a method and adding square brackets right away does not look good. So let's separate that in all tests.
E.g.
Object[] internalArray = getTestArray(); assertThat(internalArray[0]).isEqualTo(10);
No description provided.