-
-
Notifications
You must be signed in to change notification settings - Fork 501
More complicated test case for BST depth() method test #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...-algorithms/2-2-6-binary-search-tree/src/test/java/com/bobocode/cs/BinarySearchTreeTest.java
Outdated
Show resolved
Hide resolved
@RepNazar thanks a lot! 👏
@RepNazar could you also please squash your commits?
tboychuk
tboychuk
requested changes
Sep 28, 2021
...-algorithms/2-2-6-binary-search-tree/src/test/java/com/bobocode/cs/BinarySearchTreeTest.java
Outdated
Show resolved
Hide resolved
@RepNazar
RepNazar
force-pushed
the
main
branch
from
September 28, 2021 16:38
5aea90e to
e4144be
Compare
tboychuk
tboychuk
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
My pleasure. Should i also create PR into completed branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created BST depth() method implementation, that passed through tests, but wasn't working correct (you can look at it in try1 branch of my forked repo).
So i added more complicated test case, which my implementation fails, and decided to contribute it into main branch.