-
Notifications
You must be signed in to change notification settings - Fork 150
Update PriorityQueue.kt #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"arr" will never be increased for "PriorityQueue(0)"
Codecov Report
@@ Coverage Diff @@ ## master #6 +/- ## ============================================ - Coverage 62.82% 62.74% -0.08% Complexity 265 265 ============================================ Files 47 47 Lines 858 859 +1 Branches 177 178 +1 ============================================ Hits 539 539 Misses 278 278 - Partials 41 42 +1
Continue to review full report at Codecov.
|
Thanks for submitting the suggestion, would you mind changing tabs to spaces to keep it consistent with the rest of the codebase?
Can you add a test for the exception, too?
I have corrected
I think need use for testing kotlin-test-common
Then the test will become trivial
assertFails {
PriorityQueue <Int> (0)
}
I also think to separate the library from Java. Is it interesting to you?
"arr" will never be increased for "capacity <= 0"