-
Notifications
You must be signed in to change notification settings - Fork 39
Do not generate s500 since it conflicts with Ping1D Message definition - #168
Do not generate s500 since it conflicts with Ping1D Message definition #168patrickelectric wants to merge 1 commit into
Conversation
Conflict with Ping1D definition of message for set speed of sound, where they use same id by different units Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
1d1174a to
922a7e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this removal intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nops, thanks for noticing it!
@ES-Alexander
ES-Alexander
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that we're removing library support for a publicly used message set, but I'm also not sure what the alternative is if it breaks the library / causes conflicts for use-cases that were established before that message set was added...
It may be preferable to allow message sets to overwrite/extend other messages, but if I'm understanding correctly there are issues with doing that currently, which makes this a necessary evil fix for an issue that will ideally have a better solution longer term.
Please do fix the point @joaoantoniocardoso raised before merging though.
No description provided.