-
Notifications
You must be signed in to change notification settings - Fork 67
Update elfutils version and use ubuntu apt packages in dockerfile#315
Update elfutils version and use ubuntu apt packages in dockerfile #315mbmtbtbc wants to merge 1 commit into
Conversation
mbmtbtbc
commented
May 29, 2026
I worked on the Dockerfile changes and replaced the custom elfutils build with Ubuntu's libdw-dev and libelf-dev packages.
One thing I noticed while validating the change is that Ubuntu 26.04 currently provides elfutils/libdw version 0.194 rather than 0.195:
pkg-config --modversion libdw 0.194 pkg-config --modversion libelf 0.194
The Docker image builds successfully and pystack also builds and installs successfully against the distro-provided libraries.
Is 0.194 acceptable for the Docker image, or would you prefer a different approach to obtain 0.195?
codecov-commenter
commented
May 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #315 +/- ## ======================================= Coverage 79.16% 79.16% ======================================= Files 51 51 Lines 5567 5567 Branches 584 584 ======================================= Hits 4407 4407 Misses 1160 1160
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
godlygeek
commented
May 29, 2026
Is
0.194acceptable for the Docker image, or would you prefer a different approach to obtain0.195?
It's fine for us to use 0.194 in the Docker image. Since the Docker image is used only for testing, the only reason we'd need to use a newer version there is if we want to use a feature that's only available in a later version, or if we're affected by a bug in 0.194 that's fixed in a later version. If either of those ever happens, we can reintroduce the build from source at that point.
This PR will need to be rebased, though - there's a minor merge conflict between it and #313. Also, it's missing the Signed-off-by line in the commit message body - see CONTRIBUTING.md
More worryingly, it looks like the build of elfutils 0.195 is failing in the manylinux container that cibuildwheel is using...
mbmtbtbc
commented
May 30, 2026
Understood! Here's what I'll do:
- Rebase onto main to resolve the
Dockerfileconflict - Amend the commit to add the
Signed-off-byline - Dig into the manylinux build log to figure out why 0.195 is failing there
Will push an update once I've sorted it out.
Uh oh!
There was an error while loading. Please reload this page.
Issue number of the reported bug or feature request: fixes #314
Describe your changes
Replace the custom
elfutilsbuild stage in the Dockerfile with Ubuntu's packagedlibdw-devandlibelf-devdependencies.Removed the
elfutils_builderstage from the DockerfileRemoved the download and compilation of elfutils 0.193
Added
libdw-devandlibelf-devto the Ubuntu package listRemoved the copy step that imported the custom-built libraries
Updated documentation referencing the source build of elfutils
Testing performed
Successfully built the Docker image
Verified
pkg-configdetects bothlibdwandlibelfSuccessfully built and installed pystack inside the container using the distro-provided libraries
Additional context
Ubuntu 26.04currently provideselfutils/libdwversion0.194rather than0.195