Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

prawn-table support#44

Draft
blocknotes wants to merge 7 commits into
main from
support-for-prawn-table
Draft

prawn-table support #44
blocknotes wants to merge 7 commits into
main from
support-for-prawn-table

Conversation

@blocknotes

@blocknotes blocknotes commented Jul 9, 2022
edited
Loading

Copy link
Copy Markdown
Owner

Related to #34

g-pavlik reacted with eyes emoji
@blocknotes blocknotes self-assigned this Jul 9, 2022
Comment thread lib/prawn_html/tag.rb Outdated
Comment thread lib/prawn_html/tag.rb Outdated
Comment thread lib/prawn_html/tag.rb Outdated
Comment thread lib/prawn_html/tag.rb Outdated
@blocknotes blocknotes changed the title (削除) Support for prawn table (削除ここまで) (追記) prawn-table support (追記ここまで) Jul 9, 2022

Copy link
Copy Markdown

Ha! I was just starting to develop this, but you beat me to it 🙈

Let me know if you need help putting this through its paces.

blocknotes commented Sep 5, 2022
edited
Loading

Copy link
Copy Markdown
Owner Author

Ha! I was just starting to develop this, but you beat me to it 🙈
Let me know if you need help putting this through its paces.

Hey @julianrubisch.
I'm sorry to reply so late :)
Thanks for your contribution about the table closing tag.

I'm still evaluating the approach of this PR BTW.
The integration with prawn-table works but it's not as flexible as I would expect.

I'm going to try to implement my own version of table and see how it works.

g-pavlik reacted with eyes emoji

Copy link
Copy Markdown

gotcha, I can see why :-)

I'll keep playing around on my fork as I need some type of table support, however rudimentary, at the moment.

Copy link
Copy Markdown
Owner Author

I'll keep playing around on my fork as I need some type of table support, however rudimentary, at the moment.

Ok, feel free to share when you have something to show. I'm curious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /