-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(desktop): support provider-custodied agent keys - #7444
Draft
jrobotham-square wants to merge 2 commits into
Draft
feat(desktop): support provider-custodied agent keys #7444jrobotham-square wants to merge 2 commits into
jrobotham-square wants to merge 2 commits into
Conversation
Signed-off-by: Joel Robotham <jrobotham@squareup.com>
🔐 Codex Security Review
Status: review required for the current range.
The current range is
3c7f288c60d67df78577b237e27c3dfc8831aaa1...e29f4d416ba64462a1a0a68096377ac8943f53af.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review e29f4d416ba64462a1a0a68096377ac8943f53afto authorize a new review.
Any previous review applies only to its recorded range.
Signed-off-by: Joel Robotham <jrobotham@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Remote providers can now opt into owning an agent signing key. A provider advertises
registerandattesttogether, returns only the public key, and receives a NIP-OA authorization scoped to that identity.Desktop records key custody explicitly and skips local keyring and spawn paths for provider-custodied agents. It persists incomplete attestation before the provider call, keeps Start available until acknowledgement, and retries attestation through Start after an error or interrupted response. Providers without both capabilities keep the existing deploy flow.
Registration cleanup and provider-side removal remain follow-up lifecycle work.
Related issue
None found.
Testing
Manually created a provider-custodied agent against a protocol-v1 provider. Confirmed Desktop retained no private key, the provider accepted the owner authorization, and a repeat attestation succeeded.
Generated with Codex