-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Draft
Conversation
Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
🔐 Codex Security Review
Status: review required for the current range.
The current range is
3c7f288c60d67df78577b237e27c3dfc8831aaa1...bb5a2c4afc139095cf9d10524077f916116d740c.
A new review must complete for this exact range. When manual authorization
is required, a Block organization member must comment exactly
@buzz-security-review bb5a2c4afc139095cf9d10524077f916116d740cto authorize a new review.
Any previous review applies only to its recorded range.
Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
readyplus structuredRequirementrows with the existingsurfacediscriminator.Smallest truthful backend contract
This uses one dedicated Tauri command:
evaluate_agent_readiness_draft.The request explicitly distinguishes:
new: a complete standalone configuration using the same authoritativeagentCommandfield as Create;existing: an exact saved-agent identity plus the same patch semantics as Update.The command does not implement a second readiness or configuration model. Create and preview share provider/model normalization, edit and preview share update helpers, and both flow through the same fallible effective-config and harness resolution used by Start before reaching
agent_readiness.Enabling contract / deferred work
This is an enabling backend contract for the new desktop client. It intentionally does not migrate or delete the existing frontend provider/form metadata table in this PR. Consumer migration remains a follow-up once the replacement client consumes this command. The legacy runtime-status
local_setupboolean also remains unchanged for compatibility.Tests
cargo test --manifest-path desktop/src-tauri/Cargo.toml commands::agent_config --libcargo test --manifest-path desktop/src-tauri/Cargo.toml managed_agents::types::tests::update_request --libcargo test --manifest-path desktop/src-tauri/Cargo.toml managed_agents::readiness::cli_probe --libcargo test --manifest-path desktop/src-tauri/Cargo.toml managed_agents::readiness --libcargo check --manifest-path desktop/src-tauri/Cargo.toml --libcargo test --manifest-path desktop/src-tauri/Cargo.toml --features mesh-llm commands::agents::tests::created_inference_config_defaults_relay_mesh_model --libcd desktop && node --import ./test-loader.mjs --experimental-strip-types --test src/shared/api/tauri.test.mjs src/shared/lib/configNudge.test.mjscd desktop && pnpm typecheckjust file-size-checkdesktop-check,desktop-typecheck,desktop-test,desktop-tauri-checks,file-size-check.